1 2017-02-12 18:44:04 <arubi> huh.  weird, can't remember leaving the channel
 2 2017-02-12 18:44:52 <arubi> <arubi> I think I'm building the crediting transaction from script_tests.json wrong.  I can pass tests that don't have a checksig in them, but (e.g.) a p2pk test fails with a bad signature.  here's an example of both cases:  https://paste.fedoraproject.org/555262/92264814/raw/  .  the tests describe the crediting tx structure right at the beginning of the script_tests.json file.  would appreciate your input.
 3 2017-02-12 18:45:04 <arubi> ^ applies for here too
 4 2017-02-12 21:02:18 <Chris_Stewart_5> arubi: Perhaps looking at this will help? https://github.com/bitcoin-s/bitcoin-s-core/blob/master/src/test/scala/org/bitcoins/core/util/TransactionTestUtil.scala#L36
 5 2017-02-12 21:03:23 <Chris_Stewart_5> arubi: and this as well for building the spending tx https://github.com/bitcoin-s/bitcoin-s-core/blob/master/src/test/scala/org/bitcoins/core/util/TransactionTestUtil.scala#L59
 6 2017-02-12 21:04:18 <arubi> "txSpend.vout.resize(1);" ?  I thought script_tests.json says the spending tx is only an input?
 7 2017-02-12 21:04:44 <Chris_Stewart_5> No, you cannot have a tx with no outputs
 8 2017-02-12 21:06:06 <Chris_Stewart_5> well, at least in bitcoin in the network sense. Maybe inside of script evaluation you can have no outputs.
 9 2017-02-12 21:06:15 <Chris_Stewart_5> Either way, it is irrelevant. The tests in script_tests have an output
10 2017-02-12 21:06:16 <arubi> that's what I know
11 2017-02-12 21:06:17 <arubi> https://github.com/bitcoin/bitcoin/blob/9260085377e89e666d0cb95b462261d7e3a9c82f/src/test/data/script_tests.json#L5-L6
12 2017-02-12 21:06:23 <arubi> what output is that?
13 2017-02-12 21:07:10 <Chris_Stewart_5> https://github.com/bitcoin/bitcoin/blob/master/src/test/script_tests.cpp#L151-L152
14 2017-02-12 21:07:43 <arubi> oh.  thanks :)
15 2017-02-12 21:07:45 <Chris_Stewart_5> so same satoshi value as the crediting tx and an empty script
16 2017-02-12 21:07:47 <Chris_Stewart_5> np
17 2017-02-12 21:08:05 <Chris_Stewart_5> Feels good to return the favor every once in awhile :P
18 2017-02-12 21:10:18 <arubi> hehe appreciate it